Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Update issue templates to fit Github's data model #387

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Aug 2, 2019

Our current issue templates are not being picked up by Github, this PR updates the templates to fit the accepted data model in addition to some style tweaks for the templates themselves.

image

@gabbifish
Copy link
Contributor

Small comments to address, then ready to merge!

@ashleymichal
Copy link
Contributor

can you include in the description what "spec" you are following?

@EverlastingBugstopper
Copy link
Contributor Author

EverlastingBugstopper commented Aug 5, 2019

Sorry, @gabbifish I'm not seeing your comments? If your main comment was that I had bug report in the feature request - that should be resolved 😛

@EverlastingBugstopper EverlastingBugstopper force-pushed the avery/fix-issue-templates branch 3 times, most recently from 33baad6 to 190c0bf Compare August 5, 2019 14:33
@EverlastingBugstopper EverlastingBugstopper changed the title Update issue templates to follow spec Update issue templates to fit Github's data model Aug 5, 2019

#### What did you expect to see?
### Environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move environment to the very top of the issue template; it's good to have these details up front.


<!-- Please answer these questions before submitting your issue. Thanks! -->
<!--
Please fill out each section below before submitting your 🐛 bug report.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please fill out each section below before submitting your 🐛 bug report.
Please fill out each section below before submitting your 💡feature request..


<pre>
$ wrangler -V
## Description
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Description" is not super necessary here; the following fields will gather all the info we need. I'd remove this field.

labels: user report
---

### 🐛 Bug Report
# 🐛 Bug Report
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be massive text! I recommend making this ### and all other fields ####. This applies to the feature request template as well.

@EverlastingBugstopper
Copy link
Contributor Author

Comments addressed!

Copy link
Contributor

@gabbifish gabbifish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EverlastingBugstopper EverlastingBugstopper merged commit f488b47 into master Aug 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the avery/fix-issue-templates branch August 5, 2019 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants