This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Improve JSON errors debuggability #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtuc
added
changelog - feature
webpack
ashleymichal
reviewed
Aug 5, 2019
| message::success(&msg); | ||
| Ok(()) | ||
| } else { | ||
| fs::remove_file(temp_file)?; |
There was a problem hiding this comment.
if we are preserving this for forensic purposes, should we output its location?
There was a problem hiding this comment.
I assume that "forensic purposes" is similar to post mortem analysis, in that case yes. The location is available when using RUST_LOG=info. The user doesn't need to know about its exisiance.
xtuc
force-pushed
the
sven/improve-json-errors
branch
from
cd1782f
to
9cadf4c
Compare
As seen in #393 previously JSON decoding errors are obscure. This changes improve the debugging in three cases: - The `package.json` file fails to decode; now emits a clearer error. - The wranglerjs backend returns an invalid JSON; now preserves the output file for further investigation. The console doesn't print the output file location by default, you need to pass `RUST_LOG=info` while running `wrangler build` and search for `--output-file=FILE` argument passed to wranglerjs. - The preview service returns invalid JSON; now emits a clearer error and full output can be seen using `RUST_LOG=info`
xtuc
force-pushed
the
sven/improve-json-errors
branch
from
9cadf4c
to
ccced5c
Compare
ashleygwilliams
approved these changes
Aug 5, 2019
ashleymichal
approved these changes
Aug 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: improve JSON errors debuggability
As seen in #393 previously
JSON decoding errors are obscure.
This changes improve the debugging in three cases:
package.jsonfile fails to decode; now emits a clearer error.output file for further investigation.
The console doesn't print the output file location by default, you
need to pass
RUST_LOG=infowhile runningwrangler buildandsearch for
--output-file=FILEargument passed to wranglerjs.and full output can be seen using
RUST_LOG=info