Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

feat: #348 rename namespace #403

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

ashleymichal
Copy link
Contributor

@ashleymichal ashleymichal commented Aug 6, 2019

Closes #348 . Branched off of #392, merge first.

Interacting with this code looks a little something like this:
On successful creation:

$ wrangler kv rename 40de2c538b0a44f89bb8a41d4e1113c1 "renamed namespace"
🌀  Renaming namespace 40de2c538b0a44f89bb8a41d4e1113c1 to have title "renamed namespace"
✨  Success

On API error (in this case kv namespace format incorrect):

$ wrangler kv rename 40de2c538b0a44f89bb8a41d4e1113c "renamed namespace"
🌀  Renaming namespace 40de2c538b0a44f89bb8a41d4e1113c to have title "renamed namespace"
⚠️  Error 10011: could not parse UUID from request's namespace_id: 'uuid: incorrect UUID length: 40de2c538b0a44f89bb8a41d4e1113c'
🕵️‍♂️  Run `wrangler kv list` to see your existing namespaces with IDs

@ashleymichal ashleymichal self-assigned this Aug 6, 2019
@ashleymichal ashleymichal added this to the Add KV Subcommands milestone Aug 6, 2019
@ashleymichal ashleymichal added changelog - feature regression Something is broken, but works in previous releases labels Aug 6, 2019
@ashleymichal ashleymichal changed the title feat: rename namespace feat: #348 rename namespace Aug 6, 2019
@EverlastingBugstopper
Copy link
Contributor

Any reason for the : () in ✨ Success: ()? Will there ever be any useful data in the parentheses?

@ashleymichal
Copy link
Contributor Author

Any reason for the : () in ✨ Success: ()? Will there ever be any useful data in the parentheses?

that's a default debug for the output, which is effectively nothing (the endpoint returns a JSON response with result: null and just a success.

I think several of these actions will need to have their outputs "massaged". Will look at customizing outputs today.

@ashleymichal ashleymichal merged commit b5fbdd2 into feat-kv-commands Aug 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the alewis/feat-rename-namespace branch August 7, 2019 22:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression Something is broken, but works in previous releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants