This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Nits: fix clippy warnings #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xortive
commented
Aug 12, 2019
| @@ -1,3 +1,4 @@ | |||
| #![allow(dead_code)] | |||
There was a problem hiding this comment.
normally would be against this type of hammer, but I think this is an appropriate nail.
There was a problem hiding this comment.
i'm confused is it a hammer or a nail 😉
gabbifish
reviewed
Aug 13, 2019
| @@ -38,7 +38,7 @@ impl Package { | |||
|
|
|||
| let package_json: String = fs::read_to_string(manifest_path.clone())?.parse()?; | |||
| let package: Package = serde_json::from_str(&package_json) | |||
| .expect(&format!("could not parse {:?}", manifest_path)); | |||
| .unwrap_or_else(|_| panic!("could not parse {:?}", manifest_path)); | |||
There was a problem hiding this comment.
Out of curiosity, why did expect cause these warnings?
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up some clippy warnings that got past CI.