This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Gabbi/improve bulk error handling #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,6 +63,15 @@ fn print_error(e: ApiFailure) { | |||
| } | |||
| } | |||
|
|
|||
| // For handling cases where the API gateway returns errors via HTTP status codes | |||
| // (no KV error code is given). | |||
| fn give_status_code_context(status_code: StatusCode) { | |||
There was a problem hiding this comment.
this should probably eventually be pulled up and out bc the same issue would come up on any request to any api endpoint; however there's no use doing that now.
ashleymichal
approved these changes
Aug 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #465.
This PR also adds logic for handling and displaying HTTP status codes indicative of an error. This is especially useful when the API gateway returns errors before the request ever makes it to the KV API; for example, prior to this PR, uploads of payload > 100MB would silently error because wrangler looked for a KV api response that didn't exist. Instead, we should make sure wrangler handles cases like this and points out relevant information like
Err code 413--payload too large.