This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
feat: use target webworker #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtuc
added
regression
wranglerjs/index.js
Outdated
| @@ -28,6 +28,15 @@ if (args["no-webpack-config"] === "1") { | |||
| config = require(join(process.cwd(), args["webpack-config"])); | |||
| } | |||
|
|
|||
| if (config.target !== undefined && config.target !== "webworker") { | |||
| throw error( | |||
| "Building a Cloudflare Worker with target " + JSON.stringify(config.target) + | |||
There was a problem hiding this comment.
Can we use string literals here? Also putting a stringified JSON in the middle of an error message seems... interesting. Do you have an example of what this would output?
There was a problem hiding this comment.
It's adding quotes arround string, normalize priting functions, NaN, undefined, etc.
|
LGTM <3 |
EverlastingBugstopper
approved these changes
Sep 3, 2019
ashleymichal
reviewed
Sep 3, 2019
Fixes #477. We want to configure webpack to emit only webworker compatible code.
xtuc
force-pushed
the
feat-use-target-webworker
branch
from
019162e
to
e7416ff
Compare
ashleymichal
approved these changes
Sep 3, 2019
kristianfreeman
added
feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #477. We want to
configure webpack to emit only webworker compatible code.