This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Add bucket::upload, bucket::delete #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleymichal
added
changelog - feature
regression
ashleymichal
force-pushed
the
alewis/add-bucket-operations
branch
from
6404086
to
0ed02e8
Compare
gabbifish
suggested changes
Sep 3, 2019
|
also need to update documentation. |
Co-Authored-By: Gabbi Fisher <[email protected]>
gabbifish
reviewed
Sep 4, 2019
src/commands/kv/bucket.rs
Outdated
| Ok(key_value_pairs | ||
| .iter() | ||
| .map(|kv| kv.key.clone()) | ||
| .collect::<Vec<_>>()) |
There was a problem hiding this comment.
do we still think we can get rid of this cloning logic? I think it would be a good idea :)
There was a problem hiding this comment.
yes, apparently if it isn't in a PR comment I don't remember it.
gabbifish
reviewed
Sep 4, 2019
| pub fn upload(namespace_id: &str, filename: &Path) -> Result<(), failure::Error> { | ||
| let pairs: Result<Vec<KeyValuePair>, failure::Error> = match &metadata(filename) { | ||
| Ok(file_type) if file_type.is_dir() => directory_keys_values(filename), | ||
| Ok(_file_type) => { |
There was a problem hiding this comment.
Suggested change
| Ok(_file_type) => { | |
| Ok(_) => { |
📦
gabbifish
reviewed
Sep 4, 2019
| Ok(_) => { | ||
| // any other file types (namely, symlinks) | ||
| failure::bail!( | ||
| "{} should be a file or directory, but is a symlink", |
There was a problem hiding this comment.
Suggested change
| "{} should be a file or directory, but is a symlink", | |
| "wrangler kv:bucket delete takes a directory", |
gabbifish
approved these changes
Sep 4, 2019
This was referenced Sep 4, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #512 , Closes #513