Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

refactor: pass project to kv commands in prep for environments #526

Merged
merged 1 commit into from
Sep 5, 2019
Merged

refactor: pass project to kv commands in prep for environments #526

merged 1 commit into from
Sep 5, 2019

Conversation

ashleymichal
Copy link
Contributor

Reverting a misguided implementation in preparation for integration with environments work.

@ashleymichal ashleymichal added refactor status - needs review regression Something is broken, but works in previous releases labels Sep 5, 2019
@ashleymichal ashleymichal added this to the Add KV Subcommands milestone Sep 5, 2019
@ashleymichal ashleymichal self-assigned this Sep 5, 2019
gabbifish
gabbifish approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@gabbifish gabbifish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I briefly thought we could also create the api client (call api_client) in main.rs, but that (a) isn't consistent with all our other behavior and (b) I think it's odd in terms of code decomposition. As is, I say this is ready to merge!

@ashleymichal ashleymichal merged commit e3800e2 into feat-kv-commands Sep 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the alewis/refactor-pass-project branch September 5, 2019 23:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabbifish gabbifish gabbifish approved these changes

Assignees

@ashleymichal ashleymichal

Labels
refactor regression Something is broken, but works in previous releases
Projects
None yet
Milestone
Add KV Subcommands
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleymichal @gabbifish