Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

warn user to remove binding if deleted + check input for bindings #560

Merged
merged 2 commits into from
Sep 12, 2019
Merged

warn user to remove binding if deleted + check input for bindings #560

merged 2 commits into from
Sep 12, 2019

Conversation

gabbifish
Copy link
Contributor

This PR does two things:

  1. First, it provides a gentle nudge to the user to remove a binding from their wrangler.toml if they call kv:namespace delete.
  2. Next, it also validates that all bindings passed into wrangler MUST be alphabetical and only have underscores.

@gabbifish gabbifish added regression Something is broken, but works in previous releases status - needs review labels Sep 11, 2019
@gabbifish gabbifish added this to the Add KV Subcommands milestone Sep 11, 2019
EverlastingBugstopper
EverlastingBugstopper approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great :)

@gabbifish gabbifish merged commit bd9f4f5 into feat-kv-commands Sep 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the gabbi/minor-feat-fixes branch September 12, 2019 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashleymichal ashleymichal ashleymichal approved these changes

@EverlastingBugstopper EverlastingBugstopper EverlastingBugstopper approved these changes

Assignees
No one assigned
Labels
regression Something is broken, but works in previous releases
Projects
None yet
Milestone
Add KV Subcommands
Development

Successfully merging this pull request may close these issues.
3 participants
@gabbifish @ashleymichal @EverlastingBugstopper