Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Test maintenance #563

Merged
merged 4 commits into from
Sep 12, 2019
Merged

Test maintenance #563

merged 4 commits into from
Sep 12, 2019

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Sep 12, 2019 •
edited
Loading

This PR:

  • Adds workers_dot_dev to test fixtures to prevent warnings from being printed in tests and will prevent tests from failing in 1.5.0.
  • Renames incorrectly named test and adds test that does what the incorrectly named test claimed to do. Specifically this now tests if builds fail if the webpack config is web
  • Removes message from bundle cleanup helper function

@EverlastingBugstopper EverlastingBugstopper self-assigned this Sep 12, 2019
@EverlastingBugstopper EverlastingBugstopper changed the title Add workers_dot_dev to test fixtures Test maintenance Sep 12, 2019
@xtuc xtuc merged commit 413bade into master Sep 12, 2019
@xtuc xtuc deleted the avery/env-tests branch September 12, 2019 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xtuc xtuc xtuc approved these changes

Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EverlastingBugstopper @xtuc