This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Fix panic when kv: command does not have subcommand
#579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e help messages because we need to ensure those are passed into the final subcommand and not earlier in the chain
gabbifish
requested review from
kristianfreeman,
ashleymichal and
EverlastingBugstopper
… in these help messages because we need to ensure those are passed into the final subcommand and not earlier in the chain" This reverts commit d4bca99.
ashleymichal
approved these changes
Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #572.
I have to provide alternative help messages for
kv:keyandkv:bulkbecause we don't want folks to specify--bindingor--namespace-idanywhere but the last subcommand in the sequence; this is because Clap doesn't allow us to place.global()on ArgGroups yet, so we can't enforce logic requiring one of--bindingor--namespace-idinkv:subcommands; instead, we can only place them in the final subcommand :(Let me know if this doesn't make sense.