feat #450: support negate flags for publish #598

ashleymichal · 2019-09-16T23:00:16Z

closes #450

src/commands/publish/mod.rs

src/main.rs

gabbifish

small nits + agree with avery's comments, otherwise lgtm :D

src/main.rs

ashleymichal added changelog - feature regression Something is broken, but works in previous releases labels Sep 16, 2019

ashleymichal requested review from gabbifish and EverlastingBugstopper September 16, 2019 23:00

ashleymichal added this to the KV Additions milestone Sep 16, 2019

ashleymichal force-pushed the alewis/negate branch 2 times, most recently from e9eae6a to f73a8fb Compare September 17, 2019 00:47

ashleymichal changed the title ~~feat #450: support negate flags for publish, preview~~ feat #450: support negate flags for publish Sep 17, 2019

ashleymichal mentioned this pull request Sep 17, 2019

make and destroy "preview" namespaces #599

Closed

EverlastingBugstopper reviewed Sep 17, 2019

View reviewed changes

src/commands/publish/mod.rs Outdated Show resolved Hide resolved

EverlastingBugstopper reviewed Sep 17, 2019

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

gabbifish approved these changes Sep 17, 2019

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

src/main.rs Outdated Show resolved Hide resolved

src/main.rs Show resolved Hide resolved

feat #450: support negate flags for publish

c049f7e

ashleymichal force-pushed the alewis/negate branch from f73a8fb to c049f7e Compare September 18, 2019 00:24

Code Review: kebab-case flags, no double negatives

9996ad6

ashleymichal requested review from EverlastingBugstopper and gabbifish September 18, 2019 00:33

ashleymichal merged commit 4634d12 into feat-kv-additions Sep 18, 2019

delete-merged-branch bot deleted the alewis/negate branch September 18, 2019 14:41

ashleymichal mentioned this pull request Sep 20, 2019

Support negation flags for publish, preview #450

Closed

Provide feedback