-
Notifications
You must be signed in to change notification settings - Fork 337
Conversation
…to determine changed files yet (#614) * Add bucket:sync subcommand
722474b
to
bd1cb04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job!! Some tiny comments, but this is very, very close to primetime :) Approving for now, but I would love to see the tiny comments addressed as well.
Have we tested that this works for multiple bindings BTW?
let mut text_blobs = Vec::new(); | ||
|
||
if let Some(site) = &target.site { | ||
let binding = "__STATIC_CONTENT_MANFIEST".to_string(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer making this a const, if possible :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calls in constants are limited to constant functions, tuple structs and tuple variants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made with <3 from the compiler
This PR adds support for uploading text blobs and also an asset manifest that maps paths to content w/their sha-256 hash