Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Asset Manifest #629

Merged
merged 11 commits into from
Sep 19, 2019
Merged

Asset Manifest #629

merged 11 commits into from
Sep 19, 2019

Conversation

EverlastingBugstopper
Copy link
Contributor

This PR adds support for uploading text blobs and also an asset manifest that maps paths to content w/their sha-256 hash

…to determine changed files yet (#614)

* Add bucket:sync subcommand
Copy link
Contributor

@gabbifish gabbifish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!! Some tiny comments, but this is very, very close to primetime :) Approving for now, but I would love to see the tiny comments addressed as well.

Have we tested that this works for multiple bindings BTW?

let mut text_blobs = Vec::new();

if let Some(site) = &target.site {
let binding = "__STATIC_CONTENT_MANFIEST".to_string();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer making this a const, if possible :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calls in constants are limited to constant functions, tuple structs and tuple variants

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made with <3 from the compiler

src/commands/publish/upload_form/mod.rs Show resolved Hide resolved
@EverlastingBugstopper EverlastingBugstopper changed the base branch from feat-kv-additions to alewis/build-site September 19, 2019 20:49
@ashleymichal ashleymichal changed the base branch from alewis/build-site to feat-kv-additions September 19, 2019 22:16
@gabbifish gabbifish merged commit 12ecc38 into feat-kv-additions Sep 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the avery/manifest-destiny branch September 19, 2019 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants