This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Fix asset manifest logic to ensure uploaded files remain on Workers KV remote #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabbifish
added
the
regression
gabbifish
requested review from
ashleygwilliams,
ashleymichal and
EverlastingBugstopper
ashleymichal
approved these changes
Sep 20, 2019
|
Ah - yes. This is a result of me not understanding what exactly the function was used for - this makes a lot of sense to me now. edit: i guess it's more that i just didn't think about the fact that i was changing the behavior and the behavior also needed changing here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug observed yesterday, where
wrangler publish --siteseemed to publish nothing to the Workers KV remote.The bug was a missing patch of logic related to
wrangler publish --site's calling ofsync().When sync is called, it does two things:
The bug was that during the second step, the local keys did not have the file's value hash appended, and wrangler perceived the keys on the local machine as JUST their pathnames. this means that during the second delete step of sync, all the files on the remote (which had just been uploaded) were deleted!
I have now successfully deployed a site from scratch using the wrangler init and wrangler publish --site logic. I made sure to nuke my old static assets namespace and start TOTALLY from scratch to ensure it works as expected.