This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Ensure KV subcommands check for presence of required fields in wrangler.toml #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabbifish
added
status - needs review
regression
gabbifish
changed the title
src/commands/kv/mod.rs
Outdated
| missing_fields.push("account_id") | ||
| }; | ||
| if target.name.is_empty() { | ||
| missing_fields.push("name") |
There was a problem hiding this comment.
idk if this makes sense here. namespace, key, and bulk commands don't need your worker script name. sync does, but it should only be run on publish, which has its own validate logic.
There was a problem hiding this comment.
this makes sense. Happy to remove this!
There was a problem hiding this comment.
oh wait, isn't name required when you create a KV namespace?
ashleymichal
approved these changes
Sep 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #607.
UPDATE: this PR is no longer WIP; we do not need to validate account_id anymore (scope of ticket has changed as per maintainer meeting 09.23.19).
previously:
It is still considered a WIP given that this only checks for the absence of required fields like account_id for KV subcommands; it does not implement things like account_id validity checking. Do we still want to implement account_id validity checking? I am still keen to get this logic in before 1.4.0 because I don't want KV users to get confused about the error messages referenced in #607; so, I'm okay without account_id validity checking for now.