This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Add validation for workers names in wrangler init and wrangler generate #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidation for consistency
gabbifish
added
status - needs review
regression
gabbifish
requested review from
ashleygwilliams,
ashleymichal and
EverlastingBugstopper
|
i think we should actually also call this from the |
EverlastingBugstopper
approved these changes
Sep 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #470
Contains unit tests; has been tested with
wrangler initandwrangler generate.Also contains minor edits to binding names validation for consistency.