Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Add documentation for webpack behavior #724

Merged
merged 6 commits into from
Sep 26, 2019
Merged

Add documentation for webpack behavior #724

merged 6 commits into from
Sep 26, 2019

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Sep 26, 2019 •
edited by ashleymichal
Loading

Closes #721

This PR adds documentation for our default webpack behavior and how to use your own configuration with wrangler.

@EverlastingBugstopper EverlastingBugstopper added this to the 1.4.0 milestone Sep 26, 2019
@EverlastingBugstopper EverlastingBugstopper self-assigned this Sep 26, 2019
ashleygwilliams
ashleygwilliams suggested changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only thing i would add is the behavior with sites and how right now it works one way for workers one way for sites and by 1.6.0 we will have the same behavior

xtuc
xtuc reviewed Sep 26, 2019
View reviewed changes
docs/content/webpack.md Outdated Show resolved Hide resolved
xtuc
xtuc reviewed Sep 26, 2019
View reviewed changes
docs/content/webpack.md Outdated Show resolved Hide resolved
@ashleygwilliams ashleygwilliams merged commit 4a7b322 into master Sep 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the avery/webpack-docs branch September 26, 2019 19:15
@EverlastingBugstopper EverlastingBugstopper mentioned this pull request Oct 8, 2019
Closed
@shalzz shalzz mentioned this pull request Oct 9, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xtuc xtuc xtuc left review comments

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

document Custom webpack configuration behavior
3 participants
@EverlastingBugstopper @ashleygwilliams @xtuc