Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Deprecate release #751

Merged
merged 10 commits into from
Oct 8, 2019
Merged

Deprecate release #751

merged 10 commits into from
Oct 8, 2019

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Sep 30, 2019 •
edited
Loading

Breaking Changes!

Fixes #538

This PR removes the ability to pass --release to wrangler publish .

If we plan on doing a point release before 1.5.0 then this should wait.

@EverlastingBugstopper EverlastingBugstopper added this to the 1.5.0 milestone Sep 30, 2019
@EverlastingBugstopper EverlastingBugstopper requested a review from a team September 30, 2019 22:09
@EverlastingBugstopper EverlastingBugstopper self-assigned this Sep 30, 2019
@gabbifish gabbifish self-requested a review September 30, 2019 23:50
gabbifish
gabbifish suggested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@gabbifish gabbifish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super excited to see this!!!! I have some comments below :D

docs/content/environments.md Show resolved Hide resolved
src/settings/target/mod.rs Outdated Show resolved Hide resolved
src/settings/target/mod.rs Outdated Show resolved Hide resolved
src/settings/target/mod.rs Outdated Show resolved Hide resolved
@EverlastingBugstopper EverlastingBugstopper force-pushed the avery/release-the-kraken branch 3 times, most recently from 0e4dfe0 to b089cf7 Compare October 1, 2019 20:52
gabbifish
gabbifish suggested changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@gabbifish gabbifish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think there's more we can simplify here :) I can take a crack at a PoC and see what you think. I also think it would be SUPER to have a little ascii comment with the truth table fully drawn out--this would greatly help other maintainers understand this complex little bit of code.

src/settings/target/mod.rs Show resolved Hide resolved
src/settings/target/mod.rs Show resolved Hide resolved
src/settings/target/mod.rs Show resolved Hide resolved
@EverlastingBugstopper
Copy link
Contributor Author

I've been talking with the Ashley's about this PR and the general feeling is that this is an improvement to what is there already, and this PR is intended to deprecate release and not to entirely rework how we do this. I'm open to getting a refactor in (I think the way to do this is to split stuff out into a deploy config struct of some sort) which will improve readability and maintainability but for now I think I should probably just add some more comments. (yay for small incremental improvements) :)

@gabbifish if you feel like taking on a big refactor feel free and let me know if you have questions - we have some time before 1.5.0 so I'm going to step back from this PR and work on some other stuff

@EverlastingBugstopper
Copy link
Contributor Author

https://twitter.com/yaahc_/status/1180885289742434305?s=19

@EverlastingBugstopper EverlastingBugstopper changed the title [WIP] Deprecate release - do not merge until 1.5.0 Deprecate release Oct 8, 2019
@EverlastingBugstopper EverlastingBugstopper requested a review from a team October 8, 2019 17:33
@gabbifish gabbifish mentioned this pull request Oct 8, 2019
Closed
gabbifish
gabbifish suggested changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@gabbifish gabbifish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small ask left :D

src/settings/target/mod.rs Show resolved Hide resolved
gabbifish
gabbifish approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@gabbifish gabbifish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the truth table comment is AWESOME. Thanks for writing it up!!!

@EverlastingBugstopper EverlastingBugstopper merged commit de1f63f into master Oct 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the avery/release-the-kraken branch October 8, 2019 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashleymichal ashleymichal ashleymichal left review comments

@gabbifish gabbifish gabbifish approved these changes

Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Deprecate --release
3 participants
@EverlastingBugstopper @ashleymichal @gabbifish