feat(publish): better error msg on needs email verif #795
Conversation
ashleygwilliams
added
feature
ashleygwilliams
force-pushed
the
verify-email-plz-k-thx
branch
from
2f6cc93
to
191a984
Compare
|
@EverlastingBugstopper is it better now? feels awk to me but i dunno what to update it to |
ashleygwilliams
force-pushed
the
verify-email-plz-k-thx
branch
3 times, most recently
from
3940cb5
to
dce73eb
Compare
ashleygwilliams
force-pushed
the
verify-email-plz-k-thx
branch
from
dce73eb
to
75d4a84
Compare
| @@ -122,6 +121,33 @@ fn build_and_publish_script( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn error_msg(status: reqwest::StatusCode, text: String) -> String { | |||
| if text.contains("\"code\": 10034,") { | |||
There was a problem hiding this comment.
We could parse the text into a json blob if we wanted and allow for pretty formatting of error codes (e.g. access error codes directly instead of doing text.contains()). With that, we could match on error code value and elegantly print out helpful messages specific to error codes (for code 10034 and beyond)!
That being said, there's no immediate case for json parsing and handling here--the text approach is appropriate for our current error handling needs.
| }"# | ||
| .to_string(); | ||
| let result = error_msg(status, text); | ||
| assert!(result.contains("https://dash.cloudflare.com")); |
There was a problem hiding this comment.
Could we even make the error message above a string const and compare the actual result in this test to this string const?
|
@gabbifish i think the idea of actually parsing the error to make it prettier would be a great next step- i'll file an issue! |
ashleygwilliams
added
changelog - feature
and removed
feature
fixes #320