Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Clean up wranglerjs temp file #853

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

EverlastingBugstopper
Copy link
Contributor

When building a script, wranglerjs creates a temporary file to pass it off to wrangler. Unfortunately, it never removed this file. Now it does.

Copy link
Contributor

@ashleymichal ashleymichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good? idk i'd almost block on @xtuc 's review...

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you checked that it doesn't break the watch mode? We used to watch specificaly this file

@EverlastingBugstopper
Copy link
Contributor Author

yes @xtuc watching preview still works for js, webpack, and rust type projects.

@EverlastingBugstopper EverlastingBugstopper merged commit 158c280 into master Nov 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the avery/cleanup-wranglerjs branch November 7, 2019 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants