-
Notifications
You must be signed in to change notification settings - Fork 337
[dev] Handle response headers #886
[dev] Handle response headers #886
Conversation
f1e4c2d
to
6a5a226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would like to see a couple of comments again, but i won't block on it.
@@ -46,12 +47,32 @@ pub async fn dev( | |||
let server_config = server_config.clone(); | |||
async move { | |||
Ok::<_, failure::Error>(service_fn(move |req| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this closure deserves to either be a well named function in its own right, or to have a comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think i can do that since hyper doesn't re-export the type MakeServiceFn
from what I can tell. i've simplified the closure as much as i can by pulling some if it out into a separate function though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lil nit, otherwise lgtm. I'd love for it to be addressed though--this is substantial enough that I give the previous PR with the same feedback a request change :)
@gabbifish @ashleymichal i think i've addressed concerns here :) |
Fixes #872
This is now a pretty usable dev server! There's still a bunch of stuff to do but this is what I'd considered an MVP.
worker code:
Proxy and curl running in parallel