Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Make azure use latest rustc #893

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Make azure use latest rustc #893

merged 1 commit into from
Nov 20, 2019

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Nov 20, 2019 •
edited
Loading

Builds are failing for dev server - run rustup update stable after curl installer

Fixes #887

@EverlastingBugstopper EverlastingBugstopper force-pushed the avery/are-you-absolutely-azure branch 2 times, most recently from 211bf6b to fc7b192 Compare November 20, 2019 21:29
@EverlastingBugstopper EverlastingBugstopper changed the title Azure hard code rustup 1.39.0 Make azure use latest rustc Nov 20, 2019
@EverlastingBugstopper EverlastingBugstopper requested a review from a team November 20, 2019 21:34
@EverlastingBugstopper EverlastingBugstopper added this to the 1.7.0 milestone Nov 20, 2019
@EverlastingBugstopper EverlastingBugstopper self-assigned this Nov 20, 2019
gabbifish
gabbifish reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@gabbifish gabbifish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually hardcode 1.39.0, does it? It just forces an update on whatever rust version is running on Azure pipelines.

We should never hardcode rust versions in our CI.

@EverlastingBugstopper
Copy link
Contributor Author

yes - initially i was hard coding it but i've since changed my approach. edited description to reflect.

@gabbifish gabbifish self-requested a review November 20, 2019 23:17
gabbifish
gabbifish approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@gabbifish gabbifish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then!

@EverlastingBugstopper EverlastingBugstopper merged commit e55ac65 into master Nov 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the avery/are-you-absolutely-azure branch November 20, 2019 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabbifish gabbifish gabbifish approved these changes

Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Update Azure pipelines to use rust 1.39
2 participants
@EverlastingBugstopper @gabbifish