-
Notifications
You must be signed in to change notification settings - Fork 337
Conversation
Refactor: Use cloudflare-rs for calls to routes endpoints
Alewis/refactor routes
This reverts commit 7996fb8.
…ersion Update cloudflare-rs version for routes endpoints
* include (optional) id in Route struct * remove unused Route::new() method * include upload result information in output of routes deploy function * split upload script and deploy into two functions
Alewis/publish multiple routes
* pull up test consts * use FromStr trait in manifest * use variable names for empty string arguments to test toml constructors
deploy target tests
this is only marked |
can we mark it as blocked instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting changes to prevent early merge
The tests seem to include a lot of compiler warnings of "this function is never used" which we |
these are a result of the test fixture code being shared between the tests/ directory and the src tests. we can move all the deploy target tests to tests/ though, that might be better. |
👍 |
@ashleygwilliams @EverlastingBugstopper I wanted to try the Checking the URL it fetches (https://workers.cloudflare.com/get-npm-wrangler-binary/1.8.0-rc.0/x86_64-apple-darwin), I realized that it's actually a
Anychance you could re-upload the build artifacts as |
@AaronO yup! we noticed that as we did the release at the end of the day- we're hoping to fix it this morning :) |
fwiw - seeing the same on windows |
Addresses phase one of #866
This PR seeks to unblock users who require Wrangler to publish to multiple routes on a Cloudflare zone. It supports:
It does not support:
Testing this branch
see https://gist.github.com/ashleymichal/b1a3f0d881fed2544b17c3e7ee1ecc17 for testing instructions.