Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Provide a readable error message for API code 10034 - Please verify your email #320

Closed
EverlastingBugstopper opened this issue Jul 12, 2019 · 4 comments Β· Fixed by #795
Closed
Assignees
Labels
feature Feature requests and suggestions
Milestone

Comments

@EverlastingBugstopper
Copy link
Contributor

EverlastingBugstopper commented Jul 12, 2019

$ wrangler subdomain jazz
🐌  Registering your subdomain, jazz.workers.dev, this could take up to a minute.
Error: ErrorMessage { msg: "β›” There was an error creating your requested subdomain.\n Status Code: 400 Bad Request\n Msg: {\"success\":false,\"errors\":[{\"code\":7003,\"message\":\"Could not route to \\/accounts\\/workers\\/subdomain, perhaps your object identifier is invalid?\"},{\"code\":7000,\"message\":\"No route for that URI\"}],\"messages\":[],\"result\":null}" }

This should be updated to inform the user that they need to validate their email before they can register the subdomain (maybe give them a link to re-send the email?)

@EverlastingBugstopper EverlastingBugstopper added feature Feature requests and suggestions status - PR welcome labels Jul 15, 2019
@ashleygwilliams
Copy link
Contributor

error 7003 is not specific enough for us to give a good error message. @rita3ko let's chat about this!

@ashleymichal
Copy link
Contributor

i believe this particular error had to do with a missing account id in the wrangler.toml. we check for that now on publish, so it should mitigate this particular error.

wrt the reported error with subdomain registration, this is actually about to become a thing, so we'll need to handle a 10034 error (email not yet verified).

@EverlastingBugstopper
Copy link
Contributor Author

EverlastingBugstopper commented Sep 12, 2019

Update - before when I ran this command I did not include my account_id. It seems like the API allows you to register a subdomain without confirming your email

image

$ wrangler whoami
πŸ’  πŸ‘‹  You are logged with the email '[email protected]'.
$ wrangler subdomain jazz
πŸŒ€  Registering your subdomain, jazz.workers.dev, this could take up to a minute.
✨  Success! You've registered jazz.

@EverlastingBugstopper
Copy link
Contributor Author

Seems like this is expected - we should print out a nice error message for wrangler publish for an unauth'd email

$ wrangler publish
✨  Built successfully, built project size is 517 bytes.
✨  Successfully published your script.
Error: Something went wrong! Status: 403 Forbidden, Details {
  "result": null,
  "success": false,
  "errors": [
    {
      "code": 10034,
      "message": "workers.api.error.email_verification_required"
    }
  ],
  "messages": []
}

@EverlastingBugstopper EverlastingBugstopper changed the title Error message for subdomain registration w/o email-authenticated account needs updated Handle API error when publishing to workers.dev with an invalid email Sep 13, 2019
@ashleymichal ashleymichal added regression Something is broken, but works in previous releases design and removed external bug blocked labels Sep 17, 2019
@ashleymichal ashleymichal added this to the 1.4.0 milestone Sep 17, 2019
@ashleygwilliams ashleygwilliams modified the milestones: 1.4.0, 1.5.0 Sep 25, 2019
@EverlastingBugstopper EverlastingBugstopper changed the title Handle API error when publishing to workers.dev with an invalid email Provide a readable error message for API code 10034 - Please verify your email Oct 8, 2019
@EverlastingBugstopper EverlastingBugstopper added status - PR welcome and removed regression Something is broken, but works in previous releases design labels Oct 8, 2019
@ashleygwilliams ashleygwilliams self-assigned this Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature requests and suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants