This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/sneaky-snakey-preview
branch
2 times, most recently
from
June 2, 2020 21:37
80ddc7e
to
b04f349
Compare
EverlastingBugstopper
force-pushed
the
avery/sneaky-snakey-preview
branch
from
June 2, 2020 21:48
b04f349
to
5fad974
Compare
ashleymichal
suggested changes
Jun 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this has some lovely ideas; i'd like to see what happens if you pass preview
bool to get_target
instead of adding a preview_kv_namespaces
fn to Target
, and retain the plain Vec<KvNamespace>
on Target.
EverlastingBugstopper
changed the title
adds preview_id to namespace manifest definition
preview/dev namespaces
Jun 3, 2020
these tests were really just testing clap
set kv_namespaces in manifest::get_target
…rangler into avery/sneaky-snakey-preview
ashleymichal
approved these changes
Jun 4, 2020
add --preview to kv:key, kv:bulk + kv:namespace
ashleymichal
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remove the old comment and 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1032
adds
preview_id
field to items inkv_namespaces
that must be provided in order to preview a worker that has kv namespaces. this will prevent folks from accidentally screwing up their production data when usingwrangler dev
.also adds
--preview
to kv commands in order to interact with them instead of production namespaces.if preview_id and id are same:
if no preview_id is specified
if preview_id and id are different: