-
Notifications
You must be signed in to change notification settings - Fork 337
Structured out for happy publish path #1538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! Some code clean up comments; particularly around the return value of deploy::worker
and output options
5a0fdc7
to
8553fc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π lookin good!
src/deploy/mod.rs
Outdated
|
||
Ok(()) | ||
let mut addresses = Vec::new(); | ||
addresses.push(deploy_address); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there's a shortcut macro:
let addresses = vec![deploy_address];
} | ||
DeployConfig::Zoned(zoned_config) => { | ||
// this is a zoned deploy | ||
log::info!("publishing to zone {}", zoned_config.zone_id); | ||
|
||
let published_routes = publish_routes(&user, zoned_config)?; | ||
|
||
let display_results: Vec<String> = | ||
let addresses: Vec<String> = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice map π
|
||
fn as_json<T>(value: &T) | ||
where | ||
T: ?Sized + Serialize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π§βπ«
d859f00
to
f6cb1d9
Compare
Previous behavior = new behavior without flag :
New behavior with flag: