-
Notifications
You must be signed in to change notification settings - Fork 337
Update issue templates to fit Github's data model #387
Conversation
Small comments to address, then ready to merge! |
can you include in the description what "spec" you are following? |
Sorry, @gabbifish I'm not seeing your comments? If your main comment was that I had |
33baad6
to
190c0bf
Compare
190c0bf
to
37abeb6
Compare
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
|
||
#### What did you expect to see? | ||
### Environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move environment to the very top of the issue template; it's good to have these details up front.
|
||
<!-- Please answer these questions before submitting your issue. Thanks! --> | ||
<!-- | ||
Please fill out each section below before submitting your 🐛 bug report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill out each section below before submitting your 🐛 bug report. | |
Please fill out each section below before submitting your 💡feature request.. |
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
|
||
<pre> | ||
$ wrangler -V | ||
## Description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Description" is not super necessary here; the following fields will gather all the info we need. I'd remove this field.
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
labels: user report | ||
--- | ||
|
||
### 🐛 Bug Report | ||
# 🐛 Bug Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be massive text! I recommend making this ### and all other fields ####. This applies to the feature request template as well.
37abeb6
to
07d82f4
Compare
Comments addressed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
07d82f4
to
5c8f196
Compare
Our current issue templates are not being picked up by Github, this PR updates the templates to fit the accepted data model in addition to some style tweaks for the templates themselves.