Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Include the Eirini, EiriniX and Bits templates in KubeCF #1179

Closed
viovanov opened this issue Jul 30, 2020 · 2 comments · Fixed by #1259
Closed

Include the Eirini, EiriniX and Bits templates in KubeCF #1179

viovanov opened this issue Jul 30, 2020 · 2 comments · Fixed by #1259
Labels
changelog Issue must be present in the release notes. Priority: Critical Size: 5 Status: Done Implemented and PR merged suse-cap Type: Enhancement New feature or request
Milestone

Comments

@viovanov
Copy link
Member

Is your feature request related to a problem? Please describe.
These charts are not being used on their own by anyone.
Using subcharts is harder than just having templates in the main KubeCF chart.

Describe the solution you'd like
Include all template in the KubeCF chart.
Make sure to keep the namespaced value keys, so we don't break compatibility.

@jandubois
Copy link
Member

I want to work on this because I have some thoughts on how to structure the repo layout to support "addon" or "mixin" templates, based on the work I've been doing restructuring our config mechanism for the multi-stack support.

I'm not ready to start work on it right now, but have assigned to myself already. I will update this issue with more info in the next 2 days.

@andreas-kupries
Copy link
Contributor

⚠️ Ticket #792 and its PRs #1022 (+ drafts #1182, #1185) becomes moot due to this.
⚠️ If we make sure that what we want from #792 is done in the work for this ticket as well.

@viovanov viovanov mentioned this issue Sep 2, 2020
5 tasks
@fargozhu fargozhu added the changelog Issue must be present in the release notes. label Sep 3, 2020
@fargozhu fargozhu added this to the jumanji milestone Sep 3, 2020
This was referenced Sep 4, 2020
@fargozhu fargozhu added Type: Enhancement New feature or request Status: Done Implemented and PR merged labels Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog Issue must be present in the release notes. Priority: Critical Size: 5 Status: Done Implemented and PR merged suse-cap Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants