This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
refactor: Include the Eirini, EiriniX and Bits templates in KubeCF #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit everything builds and runs again, both Diego and Eirini.
7 tasks
jandubois
changed the title
Include the Eirini, EiriniX and Bits templates in KubeCF
refactor: Include the Eirini, EiriniX and Bits templates in KubeCF
Sep 1, 2020
viovanov
previously approved these changes
Sep 2, 2020
viovanov
approved these changes
Sep 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the bits-service, eirini, and eirini-extensions subcharts from
chart/charts/
tomixins/
and integrates them with the rest of kubecf. All subchart properties have been moved from e.g..Values
to.Values.bits
etc. so that user overrides remain backwards compatible, even though the templates no longer reside in a subchart.The long term goal is to have only the parts derived from cf-deployment in
charts/
and both add-ons (like autoscaler), and native release (like UAA) as separate modules undermixins
.Parts of the subcharts that are completely unused by kubecf have been removed. Same thing for some configuration options that need to be hardcoded for kubecf.
The refactoring is not completely finished, but everything is working right now, including
cf ssh
, so to unblock other Eirini-related work this PR should be reviewed/merged now and remaining work done in a followup PR.Fixes #1119
Fixes #1179
Fixes #1207
Followup work (create separate Github issues before closing this PR):
values.yaml
(andvalues.schema.yaml
) files from mixins intochart/values.yaml
etc.filechecker
tool to verify that all filenames between the main chart and all mixins are unique and not overwrite each other while merging. Also verify that alltemplates/*.yaml
file start with a line that calls_config.load
.values.yaml
and move them back there.