Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AWS S3 Terraform outputs #613

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

jochenehret
Copy link
Contributor

The new names harmonize better with the cf-deployment ops files:

Note that this is a breaking change and should be mentioned in the release notes.

@beyhan beyhan requested review from a team, nouseforaname and a-hassanin and removed request for a team June 20, 2024 14:58
Copy link

@fearoffish fearoffish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with getting these in line. Adding the aws_region doesn't hurt either.

Copy link

@a-hassanin a-hassanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@rkoster rkoster merged commit 952ba41 into cloudfoundry:main Jul 4, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants