Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add CPI method for native disk update" #2570

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Revert "Add CPI method for native disk update" #2570

merged 1 commit into from
Sep 27, 2024

Conversation

aramprice
Copy link
Member

Reverts #2555

@aramprice
Copy link
Member Author

There is something odd about the spec here https://github.com/cloudfoundry/bosh/blob/main/src/bosh-director/spec/unit/cloud_config/cloud_configs_consolidator_spec.rb#L85-L90

It seems to be relying on let's lazy creation by only referencing cc_model_1 and cc_model_2 in the setup but passing in hard-coded Database ID's corresponding to cc_model_1, cc_model_2, and cc_model_3.

@aramprice aramprice merged commit 7446683 into main Sep 27, 2024
26 checks passed
@aramprice aramprice deleted the revert-2555-update_disk branch September 27, 2024 01:19
@beyhan beyhan mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aramprice