Extract Redis tar more resilient #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root dir of the Redis tar file can have various names depending on where/ how it is downloaded: - When the tar is downloaded via the Concourse 'github-release-resource' the dir will be named 'redis-redis-<commit-hash>'. - However when the tar is manually downloaded from the redis github release (e.g. https://github.com/redis/redis/archive/refs/tags/7.0.12.tar.gz) the dir will be named 'redis-<version-number>' -> All other files of the tar are identical as they are based on the same github release. To avoid packaging errors during deploy time this change ensures that the extracted root dir of the tar file will be named 'redis-<version-number>'. This will also prevent version conflicts.
svkrieger
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root dir of the Redis tar file can have various names depending on where/ how it is downloaded:
-> All other files of the tar are identical as they are based on the same github release.
To avoid packaging errors during deploy time this change ensures that the extracted root dir of the tar file will be named 'redis-'. This will also prevent version conflicts.
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite