Fix use case of bosh-deploy-with-created-release task
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task was not able to deploy a release, which was provided as a tarball. The task was looking for a final.yml, which is not present, when providing a tarball. Added a parameter to the task, to let the user provide a release-name for the tarball.
The task bosh-deploy-with-created-release failed in the shared function `bosh interpolate`. Reason is that the generated ops-file does not use `?` to allow for non-existent release in cf-deployment.yml
Bosh expects the version field to be set, even when deploying from a local path.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
The bosh-deploy-with-created-release task did not seem to work with a release tarball. The bash script was looking for a final.yml in the config folder, which is both not present when providing the release as a tarball.
I added two input parameters to the task:
RELEASE_NAME_OF_TARBALL, which is the name of the release, which has been provided as a tarball andRELEASE_VERSION_OF_TARBALL, which is the version of that release. Both is needed to construct the ops file, to add the release to the deployment.yml.The shared function
bosh_interpolateneeded some changes as well, to support the new version parameter.Please provide contextual information.
I found #96, which also mentions about this problem, which seems to have never been fully resolved.
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
How should this change be described in release notes?
Fixed use case of
bosh-deploy-with-created-releasetask, where a release has been provided as a tarball.What is the level of urgency for publishing this change?