Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add router_groups.read to tcp router client #923

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

ameowlia
Copy link
Member

@ameowlia ameowlia commented May 3, 2021

WHAT is this change about?

What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...

As an operator, Alana wants to know if there are any misconfigured router_groups that can cause a catastrophic bug at any time

Please provide any contextual information.

Has a cf-deployment including this change passed cf-acceptance-tests?

  • YES
  • NO

Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.

  • YES - please choose the category from below. Feel free to provide additional details.
  • NO

How should this change be described in cf-deployment release notes?

Add router_groups.read to tcp_router uaa client for upcoming tcp router fix

Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?

  • YES - please specify
  • NO

Does this PR make a change to an experimental or GA'd feature/component?

  • experimental feature/component
  • GA'd feature/component

Please provide Acceptance Criteria for this change?

  1. Get the bearer token for the tcp_router client
  2. See that you can read router_groups
curl -vvv -H "Authorization: bearer [uaa token]" http://api.system-domain.com/routing/v1/router_groups

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

Team: @cloudfoundry/runtime

* this is needed for an upcoming tcp_router bug fix
* it will help fix this bug with overlapping router group ports and system component ports: cloudfoundry/routing-release#184
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/178013282

The labels on this github issue will be updated when the story is started.

@tcdowney
Copy link
Member

tcdowney commented May 4, 2021

Validation Steps

  1. Deployed CF using the ameowlia-patch-1 branch
  2. Initially targeted UAA using the cf-uaac gem and the CAPI team target_uaa script
  3. Fetched the tcp_router's UAA token by looking up the uaa_clients_tcp_router_secret secret from CredHub and running:
uaac token client get tcp_router -s $uaa_clients_tcp_router_secret
  1. Viewed my token using uaac context and confirmed it had the appropriate scopes.
  2. Confirmed I could fetch router groups from the routing-api with it using the curl from the PR description. Got the following back as a response:
[{"guid":"29ce34dc-2879-4c9c-59db-d70ea016c642","name":"default-tcp","type":"tcp","reservable_ports":"1024-1033"}]

Copy link
Member

@tcdowney tcdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @ameowlia !

@tcdowney tcdowney merged commit 6d15c83 into develop May 4, 2021
@tcdowney tcdowney deleted the ameowlia-patch-1 branch May 4, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants