Clean vars

cloudfoundry · Oct 25, 2024 · bd58111 · bd58111
1 parent f39f3d7
commit bd58111
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/.github/workflows/tests-integration-reusable.yml b/.github/workflows/tests-integration-reusable.yml
@@ -3,7 +3,7 @@
 # secrets.CLIENT_SECRET
 # secrets.GITHUB_TOKEN
 # secrets.SHEPHERD_SERVICE_ACCOUNT_TOKEN
-# vars.SHEPHERD_POOL_NAME
+# vars.TEST_FLAKE_ATTEMPTS
 
 name: "pvt: run integration tests"
 
@@ -25,6 +25,7 @@ on:
       lease-namespace:
         required: false
         type: string
+        default: 'tas-devex'
       gitRef:
         type: string
         default: ${{github.event.workflow_run.head_sha}}
@@ -72,8 +73,9 @@ jobs:
 
     - name: Install Tools
       env:
-        account_token: ${{ secrets.SHEPHERD_SERVICE_ACCOUNT_TOKEN }}
-        namespace:     ${{ inputs.lease-namespace || vars.POOL_NAMESPACE || 'tas-devex' }}
+        account_token:    ${{ secrets.SHEPHERD_SERVICE_ACCOUNT_TOKEN }}
+        lease_namespace:  ${{ inputs.lease-namespace }}
+        lease_id:         ${{ inputs.lease-id }}
       run: |
         go version
 
@@ -107,7 +109,7 @@ jobs:
         apt-get install -y build-essential unzip
 
         shepherd login service-account ${account_token}
-        shepherd get lease ${{ inputs.lease-id }} --namespace tas-devex --json | jq .output > metadata.json
+        shepherd get lease ${lease_id} --namespace ${lease_namespace} --json | jq .output > metadata.json
 
     - name: Add CATS config
       if: ${{ inputs.name == 'cats' }}

diff --git a/.github/workflows/tests-integration.yml b/.github/workflows/tests-integration.yml
@@ -57,7 +57,7 @@ on:
       - ".golangci.json"
 
 env:
-  SHEPHERD_LEASE_ID: ${{ inputs.lease_id || vars.SHEPHERD_LEASE_ID}}
+  SHEPHERD_LEASE_ID: ${{ inputs.lease_id }}
 
 jobs:
 
@@ -314,10 +314,10 @@ jobs:
     steps:
       - name: unclaim
         env:
-          account_token: ${{ secrets.SHEPHERD_SERVICE_ACCOUNT_TOKEN }}
-          namespace:     ${{ vars.POOL_NAMESPACE || 'tas-devex' }}
+          account_token:  ${{ secrets.SHEPHERD_SERVICE_ACCOUNT_TOKEN }}
+          pool_namespace: ${{ vars.POOL_NAMESPACE || 'tas-devex' }}
         run: |
           shepherd login service-account ${account_token}
           set -x
           shepherd delete lease ${{ needs.claim-env.outputs.leaseid }} \
-            --namespace ${namespace}
+            --namespace ${pool_namespace}