feat: Add move-route command to cf cli (#2302) #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add transfer-route-owner command to cf cli Co-authored-by: Shwetha Gururaj <[email protected]> * feat: update repository variable. Update workflow action * fix: remove windows 2016, swap to windows latest. Fix relative file path * chore: windows values * chore: swap to Rel instead of join * chore: main dir * chore: join on current dir * chore: clean path first * chore: try from slash * chore: remove dot syntax * chore: swap to move-route Co-authored-by: Shwetha Gururaj <[email protected]> * chore: windows tests again * chore: remove test println * chore: update path to /relationships/space from transferowner Co-authored-by: Shwetha Gururaj <[email protected]> * Change display text * Remove focus * Fix typo * Send non-array data in requestBody * Change message ordering * Create shared domain instead of private Co-authored-by: Shwetha Gururaj <[email protected]>
gururajsh
requested review from
a-b,
jdgonzaleza,
ccjaimes,
pivotalgeorge and
reedr3
PeteLevineA
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Shwetha Gururaj [email protected]
feat: update repository variable. Update workflow action
fix: remove windows 2016, swap to windows latest. Fix relative file path
chore: windows values
chore: swap to Rel instead of join
chore: main dir
chore: join on current dir
chore: clean path first
chore: try from slash
chore: remove dot syntax
chore: swap to move-route
Co-authored-by: Shwetha Gururaj [email protected]
chore: windows tests again
chore: remove test println
chore: update path to /relationships/space from transferowner
Co-authored-by: Shwetha Gururaj [email protected]
Change display text
Remove focus
Fix typo
Send non-array data in requestBody
Change message ordering
Create shared domain instead of private
Co-authored-by: Shwetha Gururaj [email protected]
Thank you for contributing to the CF CLI! Please read the following:
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Does this PR modify CLI v6, CLI v7, or CLI v8?
Please see the contribution doc above or review Architecture Guide.
Description of the Change
We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.
Why Is This PR Valuable?
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
Why Should This Be In Core?
Explain why this functionality should be in the cf CLI, as opposed to a plugin.
Applicable Issues
List any applicable Github Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?