Skip to content

Commit

Permalink
fix: pin golang alpine instead of latest
Browse files Browse the repository at this point in the history
[#187010312](https://www.pivotaltracker.com/story/show/187010312)

`golang:latest` is based on debian instead of alpine. Since we were using golang:1.22.0-alpine before we should keep using latest version of alpine `golang:alpine`.

This Dockerfile definitely needs Alpine since we perform some APK operations: #957

Also, we must keep in mind that there might be differences in the golang binaries, since Alpine binaries tend to be statically linked against MUSL instead of glibc: golang/go#62053

We might want to keep an eye on this topic to ensure our binaries are always built in a consistent way.

Thank you very much @zucchinidev 🥇 for noticing this error and letting me know :)

Keep up the good work!

Co-authored-by: Andrea Zucchini <[email protected]>
  • Loading branch information
fnaranjo-vmw and zucchinidev committed Feb 19, 2024
1 parent fe7c3be commit d36197f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang:latest AS build
FROM golang:alpine AS build
RUN apk update
RUN apk upgrade
RUN apk add --update gcc g++
Expand Down

0 comments on commit d36197f

Please sign in to comment.