Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace unmaintained uuid library #1029

Merged
merged 2 commits into from
May 29, 2024
Merged

chore: replace unmaintained uuid library #1029

merged 2 commits into from
May 29, 2024

Conversation

zucchinidev
Copy link
Contributor

#187659119

Checklist:

  • Have you added or updated tests to validate the changed functionality?
  • Have you added Release Notes in the docs repositories?
  • Have you followed the Conventional Commits specification?

blgm
blgm requested changes May 29, 2024
View reviewed changes
Copy link
Member

@blgm blgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect there to be a change to go.mod if the library has been replaced, and I don't see a change to go.mod.

@zucchinidev
Copy link
Contributor Author

You are right @blgm . I did not execute go mod tidy. It is ready now

@zucchinidev zucchinidev force-pushed the chore_replace_pborman_uuid_package_187659119 branch from afa482a to 8b3cc8a Compare May 29, 2024 15:29
@zucchinidev zucchinidev requested a review from blgm May 29, 2024 15:29
@blgm blgm merged commit 773c0f7 into main May 29, 2024
8 checks passed
@blgm blgm deleted the chore_replace_pborman_uuid_package_187659119 branch May 29, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blgm blgm blgm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Service Management Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zucchinidev @blgm