Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add a Steno sink in test env #3825

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

sethboyles
Copy link
Member

  • this gets applied to the entire test run in GithubActions and makes the test output hard to read

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@sethboyles sethboyles force-pushed the test-github-actions-logging branch 3 times, most recently from faac5e8 to 81d0f50 Compare September 17, 2024 23:12
* this gets applied to the entire test run in GithubActions and makes
  the test output hard to read
Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the test results in github and there is indeed less output

@sethboyles sethboyles merged commit da0ebcf into main Sep 20, 2024
8 checks passed
@moleske moleske deleted the test-github-actions-logging branch September 20, 2024 20:07
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Sep 20, 2024
Changes in cloud_controller_ng:

- Don't add a Steno sink in test env
    PR: cloudfoundry/cloud_controller_ng#3825
    Author: Seth Boyles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants