Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky delayed job related tests #3993

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Fix flaky delayed job related tests #3993

merged 3 commits into from
Sep 27, 2024

Conversation

johha
Copy link
Contributor

@johha johha commented Sep 27, 2024

  • Mock module alias modifications when possible
  • Run plugin test in a separate rspec command to avoid side effects
  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

- Mock module alias modifications when possible
- Run plugin test in a separate rspec command to avoid side effects
@johha johha marked this pull request as ready for review September 27, 2024 09:40
lib/tasks/spec.rake Outdated Show resolved Hide resolved
Co-authored-by: Philipp Thun <[email protected]>
@johha johha merged commit 07e84c7 into main Sep 27, 2024
8 checks passed
@johha johha deleted the fix-delayed-test-flakiness branch September 27, 2024 11:23
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Sep 27, 2024
Changes in cloud_controller_ng:

- Fix flaky delayed job related tests
    PR: cloudfoundry/cloud_controller_ng#3993
    Author: Johannes Haass <[email protected]>
    Author: Philipp Thun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants