[WIP] support Visual Basic projects #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey degrim! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/150132837 The labels on this github issue will be updated when the story is started. |
|
@Degrim Do you have a sample vbproj that works with net core ? That way we can build an integration test |
|
@dgodd I added a test fixture for Visual Basic |
itzunagi
force-pushed
the
VisualBasicSupport
branch
2 times, most recently
from
41fdfd6
to
fd89ae0
Compare
itzunagi
force-pushed
the
VisualBasicSupport
branch
from
fd89ae0
to
2ed5c1b
Compare
|
I'm amazed at how nice that vb project is, it has changed a lot since I last looked at VB. I'm about to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core 2.0 SDK supports Visual Basic projects using .vbproj project file and .vb source files. Need to detect these projects and add integration tests.