Fix contour on m1 Macs #1551
Merged
Fix contour on m1 Macs #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcdowney
requested changes
Aug 22, 2022
See envoyproxy/envoy#22261 for details. For now, v1.22-latest appears to work. v1.23-latest should work soon. We can remove this change once there's a new contour release that includes a fixed envoy.
matt-royal
force-pushed
the
pr/fix-contour-1.23-bug-on-m1-mac
branch
from
d947423
to
a98ad6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
NoWhat is this change about?
See envoyproxy/envoy#22261 for details.
For now, v1.22-latest appears to work. v1.23-latest should work soon.
We can remove this change once there's a new contour release that
includes a fixed envoy.
Does this PR introduce a breaking change?
NoAcceptance Steps
./scripts/deploy-on-kind.sh runs successfully on an M1 mac and you're able to push an appTag your pair, your PM, and/or team
Things to remember