Add handlers for Service Binding Creation #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrishna90
force-pushed
the
issues/458
branch
from
1090989
to
19c3b88
Compare
akrishna90
changed the title
akrishna90
force-pushed
the
issues/458
branch
from
19c3b88
to
813416d
Compare
- we modified the controller to pick up the secret name fromt the service instance spec insead of the service binding spec. - the service binding handler does not set the secret name on the spec, so the plan is to remove it entirely and modify any consumers to look up the secret name from the service binding status field. - removed the secretName field from ServiceBinding Spec and updated the Build and Process Controller to fetch the service binding secret name from the status. Co-authored-by: Ashwin Krishna <[email protected]> Co-authored-by: Clint Yoshimura <[email protected]> Co-authored-by: Julian Hjortshoj <[email protected]>
akrishna90
force-pushed
the
issues/458
branch
from
813416d
to
bd31786
Compare
- we modified the controller to pick up the secret name fromt the service instance spec insead of the service binding spec. - the service binding handler does not set the secret name on the spec, so the plan is to remove it entirely and modify any consumers to look up the secret name from the service binding status field. - removed the secretName field from ServiceBinding Spec and updated the Build and Process Controller to fetch the service binding secret name from the status. Co-authored-by: Ashwin Krishna <[email protected]> Co-authored-by: Clint Yoshimura <[email protected]> Co-authored-by: Julian Hjortshoj <[email protected]>
…ontrollers into issues/458 � Conflicts: � api/apis/integration/create_service_binding_test.go
akrishna90
force-pushed
the
issues/458
branch
from
9724427
to
4ea6415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#458
What is this change about?
Add handlers for Service Binding Creation
service instance spec insead of the service binding spec.
so the plan is to remove it entirely and modify any consumers to look
up the secret name from the service binding status field.
Does this PR introduce a breaking change?
Possibly--we have changed the type of the servicebinding.Spec.name to a string pointer
Acceptance Steps
see #458
Tag your pair, your PM, and/or team
@akrishna90 @matt-royal @clintyoshimura