Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume mount serviceBinding credentials onto workloads #851

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Conversation

akrishna90
Copy link
Member

Is there a related GitHub Issue?

closes #746

What is this change about?

Volume mount serviceBinding credentials onto workloads

  • Add ClusterRole required by the ServiceBinding Controller to fetch the referenced CFServiceBinding object
  • Add installation of ServiceBinding controller to deploy-on-kind script.
  • Update README with manual installation instructions

Does this PR introduce a breaking change?

no

Acceptance Steps

see issue

Tag your pair, your PM, and/or team

@gnovv

- Add ClusterRole required by the ServiceBinding Controller to fetch the referenced CFServiceBinding object
- Add installation of ServiceBinding controller to `deploy-on-kind` script.
- Update README with manual installation instructions

Co-authored-by: Akira Wong <[email protected]>
Copy link
Contributor

@gnovv gnovv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pairing with @akrishna90 LGTM!

@akrishna90 akrishna90 merged commit ab70d18 into main Mar 23, 2022
@akrishna90 akrishna90 deleted the issues-746 branch March 23, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: App Developer can see service binding credentials are volume mounted onto their workload containers
2 participants