-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PrometheusRemoteWrite Exporter #26
Add PrometheusRemoteWrite Exporter #26
Conversation
8982e4c
to
c305cde
Compare
The failure is unrelated to your change. The pipeline is failing to upload a windows2019 stemcell, which it needs to do in order to deploy a windows cell to test the otel-collector-windows job. For some reason CF-D thinks the 2019.74 windows2019 stemcell is available, but it's not in bosh.io. |
|
There was what appears to be a legitimate CI error with this change:
@benjaminguttmann-avtq can you please have a look |
@ctlong do I see it correctly that the issue is related to windows stemcells? |
@benjaminguttmann-avtq The error Carson shared did occur when compiling the package on a Windows VM but doesn't have to be specific to Windows. It looks like not all of the paths referenced in the generated go mod are vendored. Can you also remove the cf-otel-collector binary please. Thanks! |
Thanks for making these changes. Unfortunately it looks like one of the new packages required by the prometheus remote write exporter has not been included in vendor in the commit, so it won't compile:
We've also just cut v0.5.0 which will cause your current PR to have merge conflicts as the version of otel-collector has been bumped. Sorry about that. Please let us know if you're ok to rework the PR against main (this time pulling in v0.103.0 of the new exporter in the config) and add the missing package or if you would prefer us to do so. Thanks, Andrew. |
Hi @acrmp I will rework the PR and update accordingly. |
2790e0d
to
9b88ca3
Compare
Hi @acrmp , hmmm prepared it again, but the file you are talking about is still missing... maybe you know what I am doing wrong here. I added the prometheusremotewrite to src/otel-collector/config.yaml then I ran this script and ran git add and git commit. I also created a dev release and could use the binary on the VM, so a bit confused right now. Thank you |
If the file exists on the filesystem but is not staged when you run In this case I would guess that you might have gitignore set to exclude paths with |
9b88ca3
to
16054f1
Compare
@acrmp you have been totally right, found a global ignore that was ignoring pkg
Now it looks way better |
Adds prometheusremotewriteexporter to the otel collector