Move config.yaml and update scripting #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves config.yaml to src/otel-collector-builder rather than keeping it in the same folder as the generated code (src/otel-collector). - Updates scripting to use the new path for config.yaml, and to run the builder instead of installing it. Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Glenn Oppegard <[email protected]>
ctlong
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We realized that the presence of the configuration file for the cf-otel-collector binary alongside the code to generate was problematic for regenerating that code. Moving it to the
src/otel-collector-builderdirectory seems more logical, and can still generate, compile, etc. code for the cf-otel-collector insrc/otel-collector. This also means that the regenerate script can remove the entiresrc/otel-collectordir before regenerating, which prevents stale files from sticking around.Also updates any relevant scripting.