fix: config secret interpolation #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
acosta11
commented
Aug 29, 2024
•
acosta11
commented
- Pushed edge cases related to quoting of secrets into templating step; now fails if quotes are missing around template variable due to interpretation as part of the valid YAML struct.
- Allows for template variables to not be interpolated.
- Only interpolates leaf properties of the config.
- Fixes edge cases related to quoting of secrets. - Allows for template variables to not be interpolated. - Only interpolates leaf properties of the config. Signed-off-by: Carson Long <[email protected]>
ctlong
previously approved these changes
Aug 30, 2024
aqstack
approved these changes
Aug 30, 2024
mkocher
previously approved these changes
Aug 30, 2024
mkocher
reviewed
Aug 30, 2024
mkocher
reviewed
Aug 30, 2024
Signed-off-by: Andrew Costa <[email protected]>
- Adds test case for parsing template variables in arrays. - Adds test case for unquoted template varibles (invalid yaml) raising an error during template compilation. Signed-off-by: Carson Long <[email protected]>
ctlong
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.