Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ht_enabled -> smt #1215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ht_enabled -> smt #1215

wants to merge 1 commit into from

Conversation

gohar94
Copy link

@gohar94 gohar94 commented Jan 23, 2023

Update firecracker config param from ht_enabled to smt.

Fixes the following error:

2023-01-23T03:39:34.650227224 [anonymous-instance:main:ERROR:src/firecracker/src/main.rs:496] Configuration for VMM from one single json failed: Invalid JSON: unknown field `ht_enabled`, expected one of `vcpu_count`, `mem_size_mib`, `smt`, `cpu_
template`, `track_dirty_pages` at line 5 column 18

Update firecracker config param from  ht_enabled to smt
@wkozaczuk
Copy link
Collaborator

Hi,
Which firecracker version ht_enabled does not work with? I think it used to work with some versions at some point. Is this mode no longer supported?

@gohar94
Copy link
Author

gohar94 commented Jan 23, 2023 via email

@gohar94
Copy link
Author

gohar94 commented Jan 23, 2023 via email

@wkozaczuk
Copy link
Collaborator

I see the change. If we apply your patch, the firecracker.py will not work with the older version of firecracker like 0.24.0:

git diff ./scripts/firecracker.py 
diff --git a/scripts/firecracker.py b/scripts/firecracker.py
index 671342e5..67a746f7 100755
--- a/scripts/firecracker.py
+++ b/scripts/firecracker.py
@@ -136,7 +136,7 @@ class ApiClient(object):
         machine_config = {
             'vcpu_count': vcpu_count,
             'mem_size_mib': mem_size_in_mb,
-            'ht_enabled' : False
+            'smt' : False
         }
         if self.socket_less:
             self.firecracker_config['machine-config'] = machine_config


[wkozaczuk@fedora-mbpro osv]$ ./scripts/firecracker.py 
2023-01-23T14:30:12.112112782 [anonymous-instance:ERROR:src/firecracker/src/main.rs:268] Configuration for VMM from one single json failed: InvalidJson

How do we solve this? How do we make it work with all versions of firecracker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants