-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ht_enabled -> smt #1215
Open
gohar94
wants to merge
1
commit into
cloudius-systems:master
Choose a base branch
from
gohar94:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ht_enabled -> smt #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update firecracker config param from ht_enabled to smt
Hi, |
Hi Waldemar,
This is the relevant changelog: https://github.com/firecracker-microvm/firecracker/blob/6cdbdfe585a6ed159fca762e63e779925fb9feec/CHANGELOG.md
…Sent from my iPhone
On Jan 22, 2023, at 11:31 PM, WALDEMAR KOZACZUK ***@***.***> wrote:
Hi,
Which firecracker version ht_enabled does not work with? I think it used to work with some versions at some point. Is this mode no longer supported?
—
Reply to this email directly, view it on GitHub<#1215 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABRLZEMARU7RPZM7GQ7TAGTWTYCSBANCNFSM6AAAAAAUDMIO44>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Specifically: https://github.com/firecracker-microvm/firecracker/blob/6cdbdfe585a6ed159fca762e63e779925fb9feec/CHANGELOG.md#changed-3
…Sent from my iPhone
On Jan 23, 2023, at 12:52 AM, Gohar Irfan Chaudhry ***@***.***> wrote:
Hi Waldemar,
This is the relevant changelog: https://github.com/firecracker-microvm/firecracker/blob/6cdbdfe585a6ed159fca762e63e779925fb9feec/CHANGELOG.md
Sent from my iPhone
On Jan 22, 2023, at 11:31 PM, WALDEMAR KOZACZUK ***@***.***> wrote:
Hi,
Which firecracker version ht_enabled does not work with? I think it used to work with some versions at some point. Is this mode no longer supported?
—
Reply to this email directly, view it on GitHub<#1215 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABRLZEMARU7RPZM7GQ7TAGTWTYCSBANCNFSM6AAAAAAUDMIO44>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I see the change. If we apply your patch, the
How do we solve this? How do we make it work with all versions of firecracker? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update firecracker config param from ht_enabled to smt.
Fixes the following error: