Skip to content

Commit

Permalink
Removes IPv6 address insertion into BGP IPv4-only nexthop field. (#606)
Browse files Browse the repository at this point in the history
  • Loading branch information
Arvinderpal authored and murali-reddy committed Jan 30, 2019
1 parent e99b694 commit 1876993
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions pkg/controllers/routing/network_routes_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -380,14 +380,6 @@ func (nrc *NetworkRoutingController) advertisePodRoute() error {
// For ipv6 what should be next-hop value? According to this https://www.noction.com/blog/bgp-next-hop
// using the link-local address may be more appropriate.
bgp.NewPathAttributeMpReachNLRI(nrc.nodeIP.String(), prefixes),
&bgp.PathAttributeNextHop{
PathAttribute: bgp.PathAttribute{
Flags: bgp.PathAttrFlags[bgp.BGP_ATTR_TYPE_NEXT_HOP],
Type: bgp.BGP_ATTR_TYPE_NEXT_HOP,
Length: 16,
},
Value: nrc.nodeIP,
},
}

glog.V(2).Infof("Advertising route: '%s/%s via %s' to peers using attribute: %+q", subnet, strconv.Itoa(cidrLen), nrc.nodeIP.String(), attrs)
Expand Down

0 comments on commit 1876993

Please sign in to comment.