Skip to content

Commit

Permalink
fix(kube-router.go): metric message -> not error
Browse files Browse the repository at this point in the history
Running kube-router without metrics is a perfectly valid way to run
kube-router and as such it shouldn't emit an error message when a user
has not set that flag. Move the message down to Info.
  • Loading branch information
aauren committed Jan 23, 2023
1 parent eb4e6f9 commit 51d7db8
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/cmd/kube-router.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ func (kr *KubeRouter) Run() error {
go mc.Run(healthChan, stopCh, &wg)

} else {
klog.Errorf("Metrics port must be over 0 and under 65535, given port: %d", kr.Config.MetricsPort)
klog.Infof("Metrics port must be over 0 and under 65535 in order to be enabled, given port: %d",
kr.Config.MetricsPort)
klog.Infof("Disabling metrics for kube-router, set --metrics-port properly in order to enable")
kr.Config.MetricsEnabled = false
}

Expand Down

0 comments on commit 51d7db8

Please sign in to comment.